Merged
Conversation
feanil
force-pushed
the
feanil/update_courseware_links
branch
3 times, most recently
from
c0324e8 to
e1a3a6b
Compare
This was referenced Mar 31, 2025
arslanashraf7
approved these changes
Apr 4, 2025
Contributor
arslanashraf7
left a comment
arslanashraf7
left a comment
There was a problem hiding this comment.
👍 I was also able to test the redirect updated scenarios in this PR.
Contributor
|
Thanks for the review @arslanashraf7 @feanil I think this is good to go, once you rebase |
We want to remove this page and URL endpoint so we're removing all the references in the code that might point to this page. It was replaced by the sequences page in the Learning MFE years ago but the old pages were never cleaned up. We are replacing the calls with the URL for the courseware in the learning MFE. See #35803 for more details.
The courseware URL is going away but it's just used here to test the middleware. That can be test with other urls that are relevant to this middleware. Note, I was unable to re-produce the failures so I've put back using the standard `reverse` logic for fetching the URL in the test.
feanil
force-pushed
the
feanil/update_courseware_links
branch
from
e1a3a6b to
cdf2603
Compare
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small increment related to #35803
There are portions of the LMS that were redirecting to the old courseware URL which in turn would redirect to the new MFE url. The changes here bypass the extra hop in many of those cases. This is a pre-requisite to dropping the old legacy page.